Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocklist integration tests #396

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Blocklist integration tests #396

merged 2 commits into from
Jan 31, 2025
+156 −33

Conversation

ZanCorDX
Copy link
Contributor

📝 Summary

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

dvush
dvush reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@dvush dvush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a case that we test in our mev test contract when blocklisted call happens internally.

@ZanCorDX ZanCorDX merged commit 66a1c1f into develop Jan 31, 2025
5 checks passed
@ZanCorDX ZanCorDX deleted the blocklist-integration-test branch January 31, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvush dvush dvush left review comments

@ferranbt ferranbt ferranbt approved these changes

@liamaharon liamaharon Awaiting requested review from liamaharon

@metachris metachris Awaiting requested review from metachris metachris is a code owner

@sukoneck sukoneck Awaiting requested review from sukoneck sukoneck is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZanCorDX @dvush @ferranbt