New type BiddableUnfinishedBlock to avoid checking TBV of blocks built #380
+72
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
In some replaced I replaced Box for BiddableUnfinishedBlock since BlockBuildingHelper is in the process of being built and might not have a good TBV.
By using BiddableUnfinishedBlock we model that the block is ready so it always has a true_block_value.
💡 Motivation and Context
Removes annoying tests for Some(true_block_value) where we know it should be always Some.
✅ I have completed the following steps:
make lint
make test