-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Pectra devnet 6 #37
Open
ryanschneider
wants to merge
13
commits into
main
Choose a base branch
from
pectra-devnet-5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+173
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2025
ZanCorDX
pushed a commit
to flashbots/rbuilder
that referenced
this pull request
Jan 21, 2025
… DX (#364) ## 📝 Summary While getting flashbots/builder-playground#37 working I ran into a couple DX gotchas with the current `config-playground.toml` file. ## 💡 Motivation and Context - The `parallel` algoirthm was pegging all my CPUs at 100%. Also figured just running `mgp-ordering` is enough. - Having a random coinbase made it harder to test block building since we only build profitable blocks. IIRC we now have a setting to build always, but I still think it's cleaner to use the prefunded accounts from the playground. - Having debug logs helped a ton tracking down pectra issues, so I expect it's useful any time anyone is using the playground for development. --- ## ✅ I have completed the following steps: * [ ] Run `make lint` * [ ] Run `make test` * [ ] Added tests (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #32 that actually works end-to-end!
It's still somewhat of a WIP due to all the random forks/versions of our various deps I'm forced to use, including
replace
directives ingo.mod
, but it works for both pectra and decun, so IMO is safe to merge. I'll obviously clean up all the go.mod changes once clients start merging & releasing their pectra code as the testnets get closer (all clients are supposed to be testnet ready by Feb 3rd).Anyways, it works using:
And the following external binaries:
This lighthouse branch: https://github.com/pawanjay176/lighthouse/commits/refactor-mock-builder/
And this
main
version ofreth
:And our
reth115
rbuilder branch (with some minorconfig-playground.toml
changes I'll PR here shortly).With these binaries I was able to build and validate pectra blocks end-to-end!
Send a juicy tx that pays the coinbase.
And sure enough, we have a pectra block in the builder-playground output!