Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove local Prometheus instance name and Fluentbit stream name #19

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Remove local Prometheus instance name and Fluentbit stream name #19

merged 1 commit into from
Nov 14, 2024

Conversation

bakhtin
Copy link
Contributor

@bakhtin bakhtin commented Nov 13, 2024

📝 Summary

Remove local Prometheus instance name and Fluentbit stream name

⛱ Motivation and Context

  • Prometheus config will use the globally scoped instance name
  • Fluentbit will construct stream name from the instance name and the log file name

📚 References

Companion PR: flashbots/meta-observability#15

✅ I have run these commands

  • make lint
  • make test
  • go mod tidy

@bakhtin bakhtin merged commit f17ab8b into main Nov 14, 2024
2 checks passed
@bakhtin bakhtin deleted the ab-update-config-schema-1 branch November 14, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoeMahhouk MoeMahhouk MoeMahhouk approved these changes

@metachris metachris metachris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bakhtin @metachris @MoeMahhouk