Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lz4 missing from flann.pc Requires: line. #481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Sep 27, 2023

  1. Fix lz4 / HDF5 missing from flann.pc Requires: line.

    lz4 is an unconditional dependency of flann (see flann-lib#399),
    but until now was not correctly generated into the
    `Requires: lz4` line of `flann.pc`,
    because the `PKG_EXTERNAL_DEPS` variable used in `flann.pc.in`
    was not defined at all.
    
    This fixes build error `lz4.h: No such file or directory`
    for properly sandboxed builds, in which undeclared dependencies
    are not made available.
    
    Same thing for HDF5, but conditionally.
    
    For lz4, also remove the hardcode of `@LZ4_STATIC_LDFLAGS@`
    from `flann.pc.in`, as this is no longer necessary.
    That fixes an incorrect `-L` flag being generated in there, e.g.
    `-L/usr/lib;-llz4`. Thus fixes flann-lib#480.
    nh2 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    910099b View commit details
    Browse the repository at this point in the history