feat: notification wait for in send history #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
force-pushed
the
feat/notification-wait-for-refactor
branch
from
53e3b5d
to
e9d6729
Compare
moshloop
reviewed
Nov 11, 2024
models/notifications.go
Outdated
| Payload types.JSONStringMap `json:"payload,omitempty"` | ||
|
|
||
| // The duration to delay sending after its creation. | ||
| Delay *time.Duration `json:"delay,omitempty"` |
There was a problem hiding this comment.
I think this should be a timeout timestamp so that date math is not required on query - re the payload - I don't think we should be saving it, it should be re-hydrated from the config id / change it / check_id so that the notification sends out up to date info
There was a problem hiding this comment.
we do need to save the payload as it contains
- resource id (config/component/check)
- original event data to get the correct cel env.
- recipient details
we will still do send out up-to date info.
adityathebe
force-pushed
the
feat/notification-wait-for-refactor
branch
from
a983fbf
to
b832b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.