fix: don't run cron on schedule #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adityathebe isn't this a breaking change? What happens if leader election is not supported/enabled ? |
|
@moshloop if not in election-leader mode, we'll have to call |
|
@adityathebe can we not make this backwards compatible - i.e. if leaderElectionEnabled {jobs.StartOnSchedule = false} |
|
@moshloop don't know if we should be to injecting any leader election stuff inside the job struct. And I don't think backward compatibility is needed here. |
need to explicitly start the cron to support multiple replicase (leader election). This way multiple replicas can register the job without starting it and let the leader election start/stop the cron schedulers.
adityathebe
force-pushed
the
fix/dont-run-cron
branch
from
ec8ae5d
to
2155872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to explicitly start the cron to support multiple replicase (leader election).
This way multiple replicas can register the job without starting it and let the leader election start/stop the cron schedulers.