Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: leader election #2263

Merged
merged 2 commits into from
Oct 25, 2024
Merged

feat: leader election #2263

merged 2 commits into from
Oct 25, 2024

Conversation

adityathebe
Copy link
Member

No description provided.

@adityathebe adityathebe changed the title feat: use shutdown impl from duty feat: leader election Oct 21, 2024
@@ -96,6 +114,7 @@ func run(cmd *cobra.Command, args []string) {
Scheme: scheme,
LeaderElection: enableLeaderElection,
LeaderElectionNamespace: runner.WatchNamespace,
LeaderElectionID: "fa62cd4d.flanksource.com",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The election ID was just copied over from config-db and the first letter was changed.

@adityathebe adityathebe force-pushed the fix/shutdown-triggers branch 2 times, most recently from 4487754 to af1f419 Compare October 22, 2024 06:16
@adityathebe adityathebe marked this pull request as ready for review October 22, 2024 06:16
@adityathebe adityathebe linked an issue Oct 22, 2024 that may be closed by this pull request
@moshloop moshloop merged commit dbc85a6 into master Oct 25, 2024
16 checks passed
@moshloop moshloop deleted the fix/shutdown-triggers branch October 25, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leader Election - Stop/Start background job based on leader state
2 participants