Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused functions #2260

Merged
merged 2 commits into from
Oct 18, 2024
Merged

chore: remove unused functions #2260

merged 2 commits into from
Oct 18, 2024

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented Oct 18, 2024

method was never used

@adityathebe adityathebe changed the title chore: remove setupError chore: remove setupError & Fail() Oct 18, 2024
@adityathebe adityathebe changed the title chore: remove setupError & Fail() chore: remove unused functions Oct 18, 2024
var results pkg.Results
for _, conf := range ctx.Canary.Spec.Namespace {
if c.k8s == nil {
c.k8s = ctx.Kubernetes()
c.ctx = ctx
if err != nil {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err is always nil

@adityathebe adityathebe enabled auto-merge (rebase) October 18, 2024 05:02
@adityathebe adityathebe enabled auto-merge (squash) October 18, 2024 05:05
@adityathebe adityathebe enabled auto-merge (squash) October 18, 2024 05:05
@adityathebe adityathebe merged commit 03b21f7 into master Oct 18, 2024
15 checks passed
@adityathebe adityathebe deleted the chore/remove-setup-error branch October 18, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant