New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop python 3.8 #3560

Open

helpmefindaname wants to merge 3 commits into master from drop_python3.8

Collaborator

helpmefindaname commented Oct 25, 2024 •

edited

Loading

Since python3.8 is no longer supported, we can now drop it and use python3.9 features in our code, especially improving typing.

This pr does:

increase the minimum python version to 3.9 and uses it in gh-actions
update ruff to version 0.7 & fixes new linting errors
uses the python3.9 typing features
removes some methods that aren't used since longer
ensure that transformer embeddings will stay with the attention implementation that were saved, preventing precision issues after reloading.

helpmefindaname added 3 commits

October 25, 2024 14:51


          drop python 3.8


          fix unrequred type ignore statements

a30fd78


          fix transformers switching attention implementation

783ebc7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet