Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #4

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Add tests #4

merged 3 commits into from
Aug 9, 2024

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Aug 8, 2024

No description provided.

@jstucke jstucke self-assigned this Aug 8, 2024
Copy link

@vobst vobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just see the comment about nightly.

- nightly
steps:
- uses: actions/checkout@v4
- run: rustup update ${{ matrix.toolchain }} && rustup default ${{ matrix.toolchain }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it is worth testing on beta and nightly toolchains. Personally I'd not test on nightly, beta is ok as it gives us some headstart for changes that are likely to land.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the nightly build

Base automatically changed from pip-compat to main August 9, 2024 09:14
Copy link

@vobst vobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, got nothing to nitpick anymore.

@jstucke jstucke merged commit 6aa8e9e into main Aug 9, 2024
7 checks passed
@jstucke jstucke deleted the add-tests branch August 9, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants