Adding an oop example #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| for table in selected_table: | ||
| con = table(configuration=configuration) | ||
| schema_dict = con.assign_schema() | ||
| #print(f"Schema for table {con}: {schema_dict}") |
There was a problem hiding this comment.
Remove this comment
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "api_key": "" | |||
There was a problem hiding this comment.
Suggested change
| "api_key": "" | |
| "api_key": "<YOUR_API_KEY>" |
fivetran-rishabhghosh
approved these changes
Jan 23, 2025
varundhall
requested changes
Jan 30, 2025
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "api_key": "" | |||
| @@ -0,0 +1,63 @@ | |||
| import json | |||
There was a problem hiding this comment.
please add the comment here, like our other examples
Comment on lines
+2
to
+4
| from fivetran_connector_sdk import Connector | ||
| from fivetran_connector_sdk import Operations as op | ||
| from fivetran_connector_sdk import Logging as log |
There was a problem hiding this comment.
add comments like out other examples
| for table in selected_table: | ||
| con = table(configuration=configuration) | ||
| schema_dict = con.assign_schema() | ||
| #print(f"Schema for table {con}: {schema_dict}") |
| print(f"Number of {endpoint} retrieved: {len(data[endpoint])}") | ||
| except rq.exceptions.RequestException as e: | ||
| # Handle exceptions and log a warning message | ||
| log.warning(f"API request to {endpoint} failed: {e}") |
There was a problem hiding this comment.
this will not work as you've not imported, please test it
Comment on lines
+1
to
+2
| from typing import List, Optional, Union | ||
| from xml.sax.handler import property_encoding |
There was a problem hiding this comment.
looks like they are not being used in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the National Park Services API to use an OOP based logic to build the connector. This also has a new format with a Readme to walk through the code and show the output in the database itself vs in the code comments.