Merge pull request #355 from b3-it/Hanmac-duplicated-position

prevent duplicated position
firegento · Jan 4, 2022 · 10b1417 · 10b1417
2 parents 5d5a28d + be6764b
commit 10b1417
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/src/app/code/community/FireGento/MageSetup/Model/Observer.php b/src/app/code/community/FireGento/MageSetup/Model/Observer.php
@@ -290,14 +290,16 @@ public function addOptionsForAgreements(Varien_Event_Observer $observer)
                 'options'  => Mage::getSingleton('magesetup/source_revocationProductType')->getOptionArray(),
             ));
 
-            $fieldset->addField('position', 'text', array(
-                'label'    => $helper->__('Position'),
-                'title'    => $helper->__('Position'),
-                'name'     => 'position',
-                'value'    => '0',
-                'required' => true,
-                'class'    => 'validate-zero-or-greater',
-            ));
+            if (!$fieldset->getElements()->searchById('position')) {
+                $fieldset->addField('position', 'text', array(
+                    'label'    => $helper->__('Position'),
+                    'title'    => $helper->__('Position'),
+                    'name'     => 'position',
+                    'value'    => '0',
+                    'required' => true,
+                    'class'    => 'validate-zero-or-greater',
+                ));
+            }
 
             Mage::dispatchEvent('magesetup_adminhtml_checkout_agreement_edit_form', array(
                 'form'     => $form,