Add Add/Update behavior and change default behavior #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to cause this issue: https://magento.stackexchange.com/questions/225623/magento-2-fastsimpleimport-integrity-constraint-violation Anyone knows about this? |
sprankhub
reviewed
Jan 24, 2022
| @@ -10,7 +10,7 @@ | |||
| <fastsimpleimport> | |||
| <default> | |||
| <ignore_duplicates>0</ignore_duplicates> | |||
| <behavior>append</behavior> | |||
| <behavior>add_update</behavior> | |||
There was a problem hiding this comment.
This is a breaking change. To be honest, I am not sure if we should do this.
There was a problem hiding this comment.
Good catch. No, I wouldn't change the default behavior - we'd need to introduce a 2.0 then, and I don't think that would be worth it.
Everything else in this PR looks good for me.
|
I haven't experienced the error from the stackexchange link, and I'm using FastSimpleImport heavily in two bigger projects, both with configurable projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append behavior is called
Add/Updatewhich is confusing, and the realadd_updatebehavior is not available.