Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): fix end to end tests #1605

Merged
merged 16 commits into from
Jan 18, 2025
Merged

fix(js): fix end to end tests #1605

merged 16 commits into from
Jan 18, 2025
+22 −20

Conversation

hugoaguirre
Copy link
Contributor

  • Added genkit/client installation to e2e workflow
  • Removed deprecated function calls from test suite

@hugoaguirre
Copy link
Contributor Author

@pavelgj, wanted to check with you the changes on this PR...

  • Downgraded to node v20 (previously v21) to remove EBADENGINE warnings during build time
  • Installed genkit client as a dependency (package.json and lockfile got modified)
  • Forced a pnpm install with modified package.json and lock to allow Genkit client installation
  • Removed the check for a clean workspace after pnpm test:e2e since package.json and lock got modified

What are your thoughts about these changes?

@hugoaguirre hugoaguirre marked this pull request as ready for review January 17, 2025 20:18
@hugoaguirre hugoaguirre requested a review from pavelgj January 17, 2025 20:19
@hugoaguirre hugoaguirre merged commit 3a30f31 into main Jan 18, 2025
4 checks passed
@hugoaguirre hugoaguirre deleted the haguirre/fix-e2e-tests branch January 18, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelgj pavelgj pavelgj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Genkit Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugoaguirre @pavelgj