Plugins #36
Open
Plugins #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin system isn't finished yet, but this is the first version. Eventually I want to make it possible to easily extend CS with different ways of detecting spam or other unwanted messages.
Closed
It's not being used anywhere
Also make GPTC module thread safe
I had written the `bridge` platform, intended for use on the Pine chat network, and the `nothing` platform, which was just for temporary testing. Because I was done with the `nothing` platform and didn't see a future use for it, I decided to delete it and not commit it to Git. However, I mistyped the `rm` command; I'm not sure what exactly happened, but my guess is that I meant to type `rm platforms/cs_platform_n` then hit Tab, so bash would autocomplete it to `rm platforms/cs_platform_nothing.py`. It seems that I accidentally typed `rm platforms/cs_platform_b` instead; when I autocompleted this, it gave `platforms/cs_platform_bridge.py`. I don't know that I did this, but it's the only way I can see that this could have happened; it does seem likely considering that `b` and `n` are adjacent on QWERTY keyboards. Thankfully, I had a small data recovery utility that I had previously written, and I was able to find a non-erased copy of the code in my filesystem. It would have been much better, though, to not need to recover the file, or at least to have had a backup. The moral of the story is: Double-check your commands, and make frequent backups!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors quite a bit of CedarSentinel's code into plugins, which makes it more easily extensible and allows users to disable unneeded parts.