Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diag fix #7173

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Diag fix #7173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dce0c7d
Diagrams, ensure overlays take 100% of cell width
db-waltz Oct 17, 2024
c22116a
Pull request #406: Diagrams, ensure overlays take 100% of cell width
db-waltz Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion waltz-ng/client/common/hierarchy-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export function groupHierarchyByKey(tree = [], keyFn = n => n.id, acc = {}) {


export function flattenChildren(node, acc = []) {
_.forEach(node.children || [], child => {
_.forEach(node?.children || [], child => {
acc.push(child);
flattenChildren(child, acc);
});
Expand Down
8 changes: 4 additions & 4 deletions ...tity-diagrams/components/entity-overlay-diagrams/interact-view/DiagramInteractView.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@
}

$: children = $hideEmptyCells && $selectedOverlay
? _.filter(group.children, child => hasData(child, $overlayData))
: group.children;
? _.filter(group?.children, child => hasData(child, $overlayData))
: group?.children || [];

$: overlayRequiresTitle = group.data && $selectedOverlay?.showTitle;
$: overlayRequiresTitle = group?.data && $selectedOverlay?.showTitle;

$: cellData = _.get($overlayData, group.id);
$: cellData = _.get($overlayData, group?.id);

$: childKinds = _
.chain(flattenChildren(group))
Expand Down
1 change: 1 addition & 0 deletions ...ity-diagrams/components/entity-overlay-diagrams/overlays/ApplicationChangesOverlay.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@
<div>
<svg viewBox={`0 0 ${width} ${height}`}
bind:this={svgElem}
width="100%"
class:focused={renderMode === RenderModes.FOCUSED}
style="background: white">
<g class="app-summary">
Expand Down
1 change: 1 addition & 0 deletions ...nt/entity-diagrams/components/entity-overlay-diagrams/overlays/assessment/BarGraph.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
<div>
{#if renderMode !== RenderModes.FOCUSED}
<svg viewBox={`0 0 ${width} ${height}`}
width="100%"
style="background: white">
<g>
{#each counts as r}
Expand Down
1 change: 1 addition & 0 deletions ...nt/entity-diagrams/components/entity-overlay-diagrams/overlays/assessment/BoxGraph.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
<div>
<svg viewBox={`0 0 ${width} ${height}`}
shape-rendering="crispEdges"
width="100%"
style="background: white">
<g transform={`translate(${cellPadding} , ${cellPadding})`}>
{#each rows as row, idx}
Expand Down
1 change: 1 addition & 0 deletions ...entity-diagrams/components/entity-overlay-diagrams/overlays/cost/RatingCostOverlay.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
<div>
<svg class="content"
viewBox="0 0 {width} {height}"
width="100%"
style={`background: ${cellData?.totalCost ? colorScale(cellData?.totalCost) : "#fff"}`}>
<g>
<text x={width / 2}
Expand Down
Loading