Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mandatory comments on assessments #6950

Merged
merged 5 commits into from
Jan 22, 2024
Merged

mandatory comments on assessments #6950

merged 5 commits into from
Jan 22, 2024

Commits on Jan 17, 2024

  1. Allow rating scheme items to mandate comments 

    - updated the DDL

#CTCTOWALTZ-2827
finos#6708
    @db-waltz
    db-waltz committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3dc030c View commit details
    Browse the repository at this point in the history

  2. Allow rating scheme items to mandate comments 

    - updated model and dao

#CTCTOWALTZ-2827
finos#6708
    @db-waltz
    db-waltz committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a92d8b7 View commit details
    Browse the repository at this point in the history

  3. Allow rating scheme items to mandate comments 

    - updated admin screens

#CTCTOWALTZ-2827
finos#6708
    @db-waltz
    db-waltz committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1fbeaf0 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Allow rating scheme items to mandate comments 

    - update screen 'sort of' respects mandatory flag
- create screen enforces mandatory flag

Github issue explains why I've said 'sort of'.  Basically you can trick the editor into saving a rating without a comment.

#CTCTOWALTZ-2827
finos#6708
    @db-waltz
    db-waltz committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    f532c99 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Pull request finos#340: CTCTOWALTZ-2827 mandatory rating comments 6708 

    Merge in WALTZ/waltz from WALTZ/waltz-dw:CTCTOWALTZ-2827-mandatory-rating-comments-6708 to db-feature/waltz-6708-mandatory-comments-on-assessments

* commit 'f532c994c23c62b238f9ad1df697792ec6149428':
  Allow rating scheme items to mandate comments
  Allow rating scheme items to mandate comments
  Allow rating scheme items to mandate comments
  Allow rating scheme items to mandate comments
    @db-waltz
    db-waltz committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ddecb95 View commit details
    Browse the repository at this point in the history