Report Grid: person view should included non-direct apps #6692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
davidwatkins73
requested changes
Aug 4, 2023
There was a problem hiding this comment.
I think swapping this back to idSelectionOptions will make the opts variable on line 113 redundant. I think you should be able to safely remove it.
Also you may want to check to see if the utility method modifySelectionOptionsForGrid is used elsewhere. That may indicate that a similar fix is needed elsewhere.
…to waltz-6602-report-grid
…to waltz-6602-report-grid
|
Thanks incorporating the suggestions into the PR. Merging it now |
davidwatkins73
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.