Skip to content

Commit

Permalink
Change Initiatives: incomplete assessments filters
Browse files Browse the repository at this point in the history
  • Loading branch information
davidwatkins73 committed Jul 27, 2023
1 parent e59ae7a commit 3d3821e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

package org.finos.waltz.service.change_initiative;

import org.finos.waltz.common.LoggingUtilities;
import org.finos.waltz.data.GenericSelector;
import org.finos.waltz.data.ImmutableGenericSelector;
import org.finos.waltz.data.assessment_definition.AssessmentDefinitionDao;
Expand All @@ -36,13 +35,11 @@
import org.finos.waltz.model.change_initiative.ImmutableChangeInitiativeView;
import org.finos.waltz.model.rating.RatingSchemeItem;
import org.finos.waltz.schema.tables.EntityHierarchy;
import org.finos.waltz.service.DIConfiguration;
import org.jooq.Record1;
import org.jooq.Select;
import org.jooq.SelectOrderByStep;
import org.jooq.impl.DSL;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
import org.springframework.stereotype.Service;

import java.util.Collection;
Expand Down Expand Up @@ -87,7 +84,7 @@ public ChangeInitiativeViewService(ChangeInitiativeDao changeInitiativeDao,
}


public ChangeInitiativeView findForEntityReference(EntityReference ref) {
public ChangeInitiativeView getForEntityReference(EntityReference ref) {
Select<Record1<Long>> directCISelector = changeInitiativeIdSelectorFactory.apply(mkOpts(ref));

SelectOrderByStep<Record1<Long>> indirectCISelector = DSL
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public ChangeInitiativeViewEndpoint(ChangeInitiativeViewService service) {
public void register() {
String findByRefPath = WebUtilities.mkPath(BASE_URL, "entity", ":kind", ":id");

DatumRoute<ChangeInitiativeView> findByRefRoute = (req, resp) -> service.findForEntityReference(
DatumRoute<ChangeInitiativeView> findByRefRoute = (req, resp) -> service.getForEntityReference(
getEntityReference(req));

EndpointUtilities.getForDatum(findByRefPath, findByRefRoute);
Expand Down

0 comments on commit 3d3821e

Please sign in to comment.