Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade dropwizard and jetty to resolve security issue #61

Merged
merged 1 commit into from
Oct 26, 2020
Merged

upgrade dropwizard and jetty to resolve security issue #61

merged 1 commit into from
Oct 26, 2020

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Oct 26, 2020

No description provided.

@akphi akphi changed the title update dropwizard 1.3.25 to fix vulnerability update dropwizard 1.3.26 to fix vulnerability Oct 26, 2020
@akphi
Copy link
Contributor Author

akphi commented Oct 26, 2020

@gs-bracej does it mean we might have to upgrade to dropwizard@2?

@kevin-m-knight-gs
Copy link
Contributor

@akphi You just need to upgrade the jetty version. See, e.g., this: finos/legend-sdlc#38

@gs-bracej
Copy link
Contributor

Agree with @kevin-m-knight-gs . We do also need to upgrade to DW2, thats going to be a bigger piece of work though. I've created #62 for that.

@akphi akphi changed the title update dropwizard 1.3.26 to fix vulnerability upgrade dropwizard and jetty to resolve security issue Oct 26, 2020
@gs-bracej gs-bracej merged commit 0ee11fd into finos:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gs-bracej gs-bracej gs-bracej approved these changes

@pierredebelen pierredebelen Awaiting requested review from pierredebelen

Assignees
No one assigned
Labels
cla-present
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akphi @kevin-m-knight-gs @gs-bracej