Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence Component: Fix DISTINCT keyword syntax in snowflake #3368

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

kumuwu
Copy link
Contributor

@kumuwu kumuwu commented Jan 23, 2025

What type of PR is this?

  • Bug Fix

What does this PR do / why is it needed ?

Fix DISTINCT keyword syntax in snowflake

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

@kumuwu kumuwu requested a review from a team as a code owner January 23, 2025 06:01
Copy link

Test Results

  1 050 files  +1    1 050 suites  +1   2h 55m 34s ⏱️ - 1m 47s
13 971 tests +2  13 831 ✔️ +2  140 💤 ±0  0 ±0 
20 010 runs  +2  19 870 ✔️ +2  140 💤 ±0  0 ±0 

Results for commit 5d150c0. ± Comparison against base commit 66a9eef.

Copy link
Contributor

@prasar-ashutosh prasar-ashutosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-ssh16 gs-ssh16 merged commit 9a22234 into finos:master Jan 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants