Support functions with complex parameters #3356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbalasu2
changed the title
rafaelbey
previously approved these changes
Jan 16, 2025
rafaelbey
approved these changes
Jan 16, 2025
|
We should handle the parameter validation inside |
rafaelbey
requested changes
Jan 24, 2025
| String protocolObjectClassName = parameterValidationContext.protocolClassName; | ||
| try | ||
| { | ||
| Class<?> protocolObjectClass = ExecutionPlanJavaCompilerExtensionLoader.extensions().stream() |
There was a problem hiding this comment.
Class.forName(protocolObjectClassName)
| { | ||
| return Lists.mutable.<Class<? extends ExecutionPlanJavaCompilerExtension>>empty() | ||
| .with(MongoDBDocumentFormatJavaCompilerExtension.class) | ||
| .with(IngestJavaCompilerExtension.class) |
| @@ -192,6 +192,11 @@ Class meta::pure::executionPlan::EnumValidationContext extends ParameterValidati | |||
| validEnumValues: String[*]; | |||
| } | |||
|
|
|||
| Class meta::pure::executionPlan::ProtocolObjectValidationContext extends ParameterValidationContext | |||
| { | |||
| protocolClassName: String[1]; | |||
There was a problem hiding this comment.
parameterClass: Class[1];
protocolClassName: String[0..1];
|
|
||
| import java.util.Map; | ||
|
|
||
| public class IngestJavaCompilerExtension implements ExecutionPlanJavaCompilerExtension |
There was a problem hiding this comment.
We dont need this anymore
| import meta::external::language::java::factory::*; | ||
| import meta::external::language::java::transform::*; | ||
|
|
||
| function meta::external::ingest::platformBinding::ingestLegendJavaPlatformBindingExtension(): meta::pure::executionPlan::platformBinding::legendJava::LegendJavaPlatformBindingExtension[1] |
There was a problem hiding this comment.
We dont need this anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
-> Improvement
What does this PR do / why is it needed ?
-> Add getter method generators to protocol generation
-> Support functions with complex parameters