Correct prompt for common controls, update controls schema, fix broken links. #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshiells-scottlogic
changed the title
|
@eddie-knight can you take a look at this please? Now that we have all links fixed should we update and prevent merging if someone adds a broken link? For the yaml-checker @mlysaght2017 do you want to take a look at the inclusion of tactics in services/database/relational/threats.yaml and update accordingly and then we could prevent merge in the case of schema validation failures? |
eddie-knight
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct prompt for common controls
Fix broken links
Update controls schema to allow for service level threats to be specified.