Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: add accessible traits to Broadcast component #1394

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Internal: add accessible traits to Broadcast component #1394

merged 1 commit into from
Jan 22, 2025

Conversation

robinsalehjan
Copy link
Contributor

Why?

  • Missing accessibility traits

What?

  • Make BroadcastMessage accessible and set the accessibilityTraits for BroadcastMessage to .summaryElement

    This accessibility element provides summary information when the app starts.

  • Make BroadcastItem accessible and set the accessibilityTraits to staticText

Version Change

  • Minor

@robinsalehjan robinsalehjan requested review from a team, dinsen, bstien, teddyfahi, ag12 and AndreyMomot and removed request for a team January 22, 2025 12:17
dinsen
dinsen approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@dinsen dinsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@robinsalehjan robinsalehjan merged commit b3b32b2 into master Jan 22, 2025
1 check passed
@robinsalehjan robinsalehjan deleted the NMPAPP-1545/make-broadcast-message-accessible branch January 22, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinsen dinsen dinsen approved these changes

@bstien bstien Awaiting requested review from bstien bstien was automatically assigned from finn-no/ios

@teddyfahi teddyfahi Awaiting requested review from teddyfahi

@ag12 ag12 Awaiting requested review from ag12

@AndreyMomot AndreyMomot Awaiting requested review from AndreyMomot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robinsalehjan @dinsen