Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Arduino.h to fix compiler warnings #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LuAPi
Copy link

@LuAPi LuAPi commented May 27, 2022

Related issue # and issue behavior

Compiler generates warnings

.arduino15/packages/arduino/tools/CMSIS-Atmel/1.2.0/CMSIS/Device/ATMEL/samd21/include/samd21g18a.h:226:0: warning: "LITTLE_ENDIAN" redefined
 #define LITTLE_ENDIAN          1

.arduino15/packages/arduino/tools/arm-none-eabi-gcc/7-2017q4/arm-none-eabi/include/machine/endian.h:17:0: note: this is the location of the previous definition
 #define LITTLE_ENDIAN _LITTLE_ENDIAN

from files

BME280/src/BME280.cpp:31
BME280/src/BME280I2C.cpp:31

When building for Arduino Nano 33 IoT

Description of changes/fixes

Including Arduino.h stops these warnings being generated.

@mention a person to review

Steps to test

Build with and without these changes in an environment that doesn't supress warnings.

Any outstanding TODOs or known issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant