Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(coord): Adding ApplyLimitFunction support for cross-partition query routing #1833

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vishramachandran
Copy link
Member

@vishramachandran vishramachandran commented Aug 9, 2024

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)

When query is routed to different partition for multi-ns queries, we see this type of error

invalid_query: Logical plan to query not supported for ApplyLimitFunction.....

This PR fixes the logical plan to query translation and also removes the default handler.

@@ -209,6 +209,12 @@ object LogicalPlanParser {
}$ClosingCurlyBraces"
}

private def applyLimitToQuery(lp: ApplyLimitFunction): String = {
val periodicSeriesQuery = convertToQuery(lp.vectors)
s"$periodicSeriesQuery limit ${lp.limit}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious if limit 1 will return 1 time series or 2 time series at the end if we have two partition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants