Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for prefixes and suffixes #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support for prefixes and suffixes #10

wants to merge 1 commit into from

Conversation

jcohenho
Copy link

@jcohenho jcohenho commented Mar 5, 2022 •
edited
Loading

Fixes #6

This PR does the following:

  1. Adds support for both prefixes and suffixes
  2. Adds error messages when trying to configure more than one prefix or suffix per event
  3. Bugfix for when no prefix or suffix option is configured (the plugin breaks)

@jcohenho jcohenho force-pushed the add-prefix-suffix-support branch from 1620ff8 to 7698be0 Compare March 10, 2022 02:00
dani-mp
dani-mp reviewed Mar 10, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@jcohenho jcohenho marked this pull request as ready for review March 11, 2022 00:15
@jcohenho
Adds support for prefixes and suffixes and a bugfix for having no pre…
43b5f54 
…fix/suffix option at all

Update index.js

Co-authored-by: Daniel Martín <[email protected]>

Update index.js

Co-authored-by: Daniel Martín <[email protected]>

Update index.js

Co-authored-by: Daniel Martín <[email protected]>

Update index.js

Co-authored-by: Daniel Martín <[email protected]>

Update index.js

Co-authored-by: Daniel Martín <[email protected]>

Update index.js

Co-authored-by: Daniel Martín <[email protected]>

split prefix/suffix error into separate errors

fix comparison logic for prefix/suffix

refactor logic for filter options
@jcohenho jcohenho force-pushed the add-prefix-suffix-support branch from ce4fe88 to 43b5f54 Compare March 11, 2022 00:18
@jcohenho jcohenho changed the title Adds support for prefixes and suffixes and a bugfix for having no pre… Support for prefixes and suffixes Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-mp dani-mp dani-mp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

better prefix support
2 participants
@jcohenho @dani-mp