Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #6441

Merged
merged 1 commit into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Filecoin, including venus and all related modules, follows the

## How can I contribute?

Here at `venus`, there’s always a lot of work to do. There are many ways you can support the project, from progamming, writing, organizing, and more. Consider these as starting points:
Here at `venus`, there’s always a lot of work to do. There are many ways you can support the project, from programming, writing, organizing, and more. Consider these as starting points:

- **Submit bugs**: Perform a cursory [search](https://github.com/filecoin-project/venus/issues) to see if the problem has already been reported. If it does exist, add a 👍 to the issue to indicate this is also an issue for you, and add a comment if there is extra information you can contribute. If it does not exist, [create a new issue](https://github.com/filecoin-project/venus/issues/new/choose) (using the Bug report template).

Expand Down
2 changes: 1 addition & 1 deletion designdocs.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ having to parse all the discussions that went into it.
## FAQ

##### How do I know what warrants a designdoc?
A designdoc is a tool so like any apply it judiciously. If you’re building something that other devs are going to work within, or with, and it’s going to take you weeks or months to do it, it’s probably a good candidate for a designdoc. Or if it’s something critically important to the project, that’s probably also worth one. Or if it's a separate thingy with its own structure, then too.
A designdoc is a tool so like any apply it judiciously. If you’re building something that other devs are going to work within, or with, and it’s going to take you weeks or months to do it, it’s probably a good candidate for a designdoc. Or if it’s something critically important to the project, that’s probably also worth one. Or if it's a separate thing with its own structure, then too.

##### But what if the designdoc is wrong?
With probability 1 it will be wrong. The point is to explicitly communicate what we are and are not trying to accomplish and to rationalize a proposal. It’s a planning tool and as soon as it is finished reality will start to diverge. But as they say: plans are worthless but planning is indispensable.
Expand Down
2 changes: 1 addition & 1 deletion pkg/paychmgr/simple.go
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@ func (pm *Manager) restartPending(ctx context.Context) error {
return group.Wait()
}

// getPaychWaitReady waits for a the response to the message with the given cid
// getPaychWaitReady waits for the response to the message with the given cid
func (ca *channelAccessor) getPaychWaitReady(ctx context.Context, mcid cid.Cid) (address.Address, error) {
ca.lk.Lock()

Expand Down
2 changes: 1 addition & 1 deletion pkg/vf3/signer.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type signer struct {
}

// Sign signs a message with the private key corresponding to a public key.
// The the key must be known by the wallet and be of BLS type.
// The key must be known by the wallet and be of BLS type.
func (s *signer) Sign(ctx context.Context, sender gpbft.PubKey, msg []byte) ([]byte, error) {
addr, err := address.NewBLSAddress(sender)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion venus-shared/types/tipset_key.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func NewTipSetKey(cids ...cid.Cid) TipSetKey {
type TipSetKey struct {
// The internal representation is a concatenation of the bytes of the CIDs, which are
// self-describing, wrapped as a string.
// These gymnastics make the a TipSetKey usable as a map key.
// These gymnastics make a TipSetKey usable as a map key.
// The empty key has value "".
value string
}
Expand Down
Loading