refactor(eth): attach ToFilecoinMessage converter to EthCall type #12062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks have passed |
raulk
force-pushed
the
raulk/refactor-eth-message
branch
from
c538885
to
3d98bd0
Compare
|
Thanks for the PR! Aarsh will do a pass on it when he is back (he is OOO today). In the meantime, it looks like you need to run: |
Stebalien
approved these changes
Jun 3, 2024
|
Er, sorry, I didn't see the comment from @rjan90. |
Make gen / Make docsgen-cli
|
Pushed make gen / make doscgen-cli, to unblock this PR (hope that was okay Raul) so that we can merge it. |
|
Test failure looks real. |
|
@rjan90 thanks for running make! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor to clean things up.