Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sleeper Drop Empty Drafts #425

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Sleeper Drop Empty Drafts #425

merged 1 commit into from
Jan 3, 2024

Conversation

JoeSydlowski
Copy link
Member

Filter out empty drafts from sleeper

Test example should have 2 draft ids

conn <- sleeper_connect(2019, "464109311174373376")
draft <- ff_draft(conn)

unique(draft$draft_id)

tanho63
tanho63 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@tanho63 tanho63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@tanho63 tanho63 enabled auto-merge (squash) January 3, 2024 04:41
@tanho63 tanho63 merged commit 4b61a17 into ffverse:main Jan 3, 2024
7 checks passed
@JoeSydlowski JoeSydlowski deleted the sleeper-drop-empty-drafts branch January 3, 2024 04:49
tanho63 added a commit that referenced this pull request Jan 28, 2024
@caltonji @JoeSydlowski @tanho63
Start Yahoo Implementation #336 (#424)
4b9c680 
* filter out empty drafts from sleeper ff_draft (#425)

* Update R-CMD-check.yaml

* Add yahoo_connect and yahoo_franchises

* Add autogenerated documentation

* Add support for ff_connect

* Run styler

* Added support for co_owners

* Update styling.  Switch userleagues to be more R like

* Switch to asking for season

* Switch to API call for game_id

* Small fixes

* add some mocked tests

* remove bypass of local_mock_api()

* Update R/yahoo_connect.R

Co-authored-by: Tan Ho <[email protected]>

* use getElement

* getElement

---------

Co-authored-by: JoeSydlowski <[email protected]>
Co-authored-by: Tan Ho <[email protected]>
Co-authored-by: Tan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanho63 tanho63 tanho63 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeSydlowski @tanho63