fix mfl scoring bug, resolves #403

ffverse · Jul 31, 2023 · 839690b · 839690b
1 parent b2dc63a
commit 839690b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: ffscrapr
 Title: API Client for Fantasy Football League Platforms
-Version: 1.4.8.04
+Version: 1.4.8.05
 Authors@R: 
     c(person(given = "Tan",
              family = "Ho",

diff --git a/NEWS.md b/NEWS.md
@@ -8,6 +8,7 @@ should be more robust (#397, thank you @logan-888!) (v1.4.8.02)
 positions that did not have dedicated posititions (#400, thank you @mcarman8!) 
 (v1.4.8.03)
 - `ff_scoring.mfl_conn()` now works better with new dplyr versions (#402) (v1.4.8.04)
+- `ff_schedule.mfl_conn()` bug fixed re: removing bad spreads (#403) (v1.4.8.05)
 
 # ffscrapr 1.4.8
 

diff --git a/R/mfl_schedule.R b/R/mfl_schedule.R
@@ -69,7 +69,7 @@ ff_schedule.mfl_conn <- function(conn, ...) {
     dplyr::filter(!is.na(.data$franchise_id))
 
   if("spread" %in% names(full_schedule)){
-    full_schedule$result[(!is.na(full_schedule$spread)|full_schedule$spread==0) && full_schedule$result == "T"] <- NA
+    full_schedule$result[(!is.na(full_schedule$spread) | full_schedule$spread==0) & full_schedule$result == "T"] <- NA
   }
 
   return(full_schedule)