Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] direct usage of pip install #2625

Closed
wants to merge 4 commits into from
Closed

Conversation

solarw
Copy link
Contributor

@solarw solarw commented Sep 14, 2021

Proposed changes

direct usage of pip install

Fixes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

DELETE INCLUSIVE THIS AND BELOW FOR STANDARD PR

Release summary

Version number: [e.g. 1.0.1]

Release details

Describe in short the main changes with the new release.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side), from develop
  • Lint and unit tests pass locally and in CI
  • I have checked the fingerprint hashes are correct by running (scripts/generate_ipfs_hashes.py)
  • I have regenerated the latest API docs
  • I built the documentation and updated it with the latest changes
  • I have added an item in HISTORY.md for this release
  • I bumped the version number in the aea/__version__.py file.
  • I bumped the version number in every Docker image of the repo and published it. Also, I built and published them with tag latest
    (check the READMEs of aea-develop
    and aea-user)
  • I have pushed the latest packages to the registry.
  • I have uploaded the latest aea to PyPI.
  • I have uploaded the latest plugins to PyPI.

Further comments

Write here any other comment about the release, if any.

@solarw solarw marked this pull request as draft September 14, 2021 00:07
@codecov-commenter
Copy link

Codecov Report

Merging #2625 (18e5cda) into develop (4544eaf) will decrease coverage by 10.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2625       +/-   ##
============================================
- Coverage    99.89%   89.34%   -10.55%     
============================================
  Files          520      521        +1     
  Lines        35695    35814      +119     
============================================
- Hits         35658    31999     -3659     
- Misses          37     3815     +3778     
Flag Coverage Δ
unittests 89.34% <100.00%> (-10.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aea/cli/install.py 86.84% <100.00%> (-13.16%) ⬇️
aea/helpers/install_dependency.py 100.00% <100.00%> (ø)
packages/fetchai/protocols/tac/serialization.py 6.63% <0.00%> (-93.37%) ⬇️
...ages/fetchai/protocols/ledger_api/serialization.py 7.42% <0.00%> (-92.58%) ⬇️
...ages/fetchai/protocols/prometheus/serialization.py 12.50% <0.00%> (-87.50%) ⬇️
packages/fetchai/protocols/acn/serialization.py 14.77% <0.00%> (-85.23%) ⬇️
...ges/fetchai/protocols/aggregation/serialization.py 15.00% <0.00%> (-85.00%) ⬇️
packages/fetchai/protocols/yoti/serialization.py 15.58% <0.00%> (-84.42%) ⬇️
...ckages/fetchai/protocols/register/serialization.py 16.21% <0.00%> (-83.79%) ⬇️
packages/fetchai/skills/tac_control/handlers.py 21.33% <0.00%> (-78.67%) ⬇️
... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4544eaf...18e5cda. Read the comment docs.

@solarw
Copy link
Contributor Author

solarw commented Oct 5, 2021

opened an issue: #2646
problem with ci crashes is not resolved yet

@solarw solarw closed this Oct 5, 2021
@DavidMinarsch DavidMinarsch deleted the feature/direct_usage_of_pip branch October 15, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants