Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tag example appearing in tags #63

Merged
merged 3 commits into from
Jul 26, 2024
Merged

fix tag example appearing in tags #63

merged 3 commits into from
Jul 26, 2024

Conversation

rekomodo
Copy link
Collaborator

@rekomodo rekomodo commented Jul 25, 2024 •
edited
Loading

solves #61

@rekomodo
Copy link
Collaborator Author

this approach just ignores the page altogether, which makes sense since it's a sphinx setting, not a sphinx-tags setting
I have another approach in mind

RemDelaporteMathurin
RemDelaporteMathurin approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's clever! Haha 😄

You should mention this hack in melissawm/sphinx-tags#105

@RemDelaporteMathurin RemDelaporteMathurin merged commit 155f9c2 into festim-dev:main Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemDelaporteMathurin RemDelaporteMathurin RemDelaporteMathurin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekomodo @RemDelaporteMathurin @jairRS