Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add landing-page to schema #5108

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

elissa-alarmani
Copy link

Fixes #4830 by adding landing-page documentation to global-configuration.mdx

I was not completely sure if adding the Landing page configuration was necessary since it consists of just the page and path values, but I included it for extra clarity.

@coderabbitai summary

@dannysheridan dannysheridan requested review from dannysheridan and removed request for dsinghvi November 5, 2024 02:35
@dannysheridan
Copy link
Member

dannysheridan commented Nov 5, 2024

manually ran the preview-docs github action

https://fern-preview-f9c70bc4-fd4f-463a-865e-2122f42d9d7f.docs.buildwithfern.com/learn/docs/getting-started/global-configuration

--> did not work as expected unfortunately. did not incorporate these changes.

@dannysheridan
Copy link
Member

dannysheridan commented Nov 5, 2024

[challenge] @elissa-alarmani if you want to figure out how an open source contributor can get the PR preview action to run, I'm all ears. would be nice if it could be triggered by a comment or action from any of the maintainers of the project.

@@ -390,3 +395,18 @@ Be sure the repository is set to **public** visibility.
<ParamField path="github.branch" type="string" required={true}>
The branch of the repository you would like the GitHub editor to open a PR to. Default is `main`.
</ParamField>

## Landing page configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elissa-alarmani think it'd be helpful to link out to Cohere's example that's open source and live in production?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

document: landing-page schema within docs.yml
2 participants