fix(cli): Set instance when migrating Mintlify > Fern
#5093
Conversation
mattblank11
changed the title
instance when migrating Mintlify > Ferninstance when migrating Mintlify > Fern
mattblank11
changed the title
instance when migrating Mintlify > Ferninstance when migrating Mintlify > Fern
| builder.setInstance({ | ||
| companyName: mint.name | ||
| }); | ||
| this.context.logger.debug("Set instance"); |
There was a problem hiding this comment.
do we want to output the name here, as well?
There was a problem hiding this comment.
@RohinBhargava are you thinking that we should output the name from the mint file or the name we auto-generate?
There was a problem hiding this comment.
good question! I think you have the most context, but I would assume mint.name, given the locality of the debug statement to the invocation
There was a problem hiding this comment.
@mattblank11 could see this being: Added instance ${url} to docs.yml
There was a problem hiding this comment.
Appreciate the input!
I agree with @dsinghvi on returning the url, if anything. IMO it's weird to return a string from the setInstance function but I don't love the alternative of creating a separate getInstanceUrl function. Feel free to push back on this!
mattblank11
changed the title
instance when migrating Mintlify > Ferninstance when migrating Mintlify > Fern
Related to this task
Here's what the
docs.ymlfile looks like for Bland AI with the instances value set:@coderabbitai summary