feat(typescript): Implement type literal AST for TS #5057
Merged
+385
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajgateno
force-pushed
the
alberto/ts-ast-basic-object-instantiation
branch
from
8c9a312
to
6f454e5
Compare
amckinney
reviewed
Oct 31, 2024
Comment on lines
99
to
110
| if (this.internalType.value.includes("\n")) { | ||
| writer.write("`"); | ||
| const parts = this.internalType.value.split("\n"); | ||
| const head = parts[0] + "\n"; | ||
| const tail = parts.slice(1).join("\n"); | ||
| writer.write(head.replaceAll("`", "\\`")); | ||
| writer.writeNoIndent(tail.replaceAll("`", "\\`")); | ||
| writer.write("`"); | ||
| } else { | ||
| writer.write(`"${this.internalType.value.replaceAll('"', '\\"')}"`); | ||
| } | ||
| break; |
There was a problem hiding this comment.
Nice - for readability, what if we made a couple helper functions for this? I imagine something like:
if (this.internalType.value.includes("\n") {
this.writeStringWithBackticks(this.internalType.value);
break;
}
this.writeStringWithQuotes(this.internalType.value);
break;Then I imagine the helper might be as simple as the following:
function writeStringWithBackticks({writer, value} : {writer: Writer; value: string; }) {
writer.write("`");
writer.writeNoIndent(this.internalType.value.replaceAll("`", "\\`"));
writer.write("`");
}Similarly, writeStringWithQuotes could use the same structure:
function writeStringWithBackticks({writer, value} : {writer: Writer; value: string; }) {
writer.write('"');
writer.write(this.internalType.value.replaceAll('"', '\\"'));
writer.write('"');
}There was a problem hiding this comment.
Discussed offline - this actually handles multi-line strings better than I expected and we should do something similar elsewhere. Nicely done!
amckinney
approved these changes
Oct 31, 2024
Comment on lines
+39
to
+44
| interface Tuple { | ||
| type: "tuple"; | ||
| // TODO: In theory this should be a tuple type, not an array of types | ||
| valueTypes: Type[]; | ||
| values: TypeLiteral[]; | ||
| } |
There was a problem hiding this comment.
I wonder if the value and valueType should be a single interface so that it's impossible for the length to be inconsistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an AST node to represent type literals in the typescript codegen module.