-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: plumb multipart form encoding in fdr #780
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
🌿 Preview your docs: https://fern-preview-3c128602-4ab6-44c1-963f-1f31d87bae60.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-108ef5ca-78a3-4e23-8d55-93a02c7191df.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-ee8058d2-7ce1-4b7f-9ea3-18140d089815.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-d60df7d4-bd41-4b0b-89d2-75dae5dbbec6.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-ba88ac28-1261-4434-a96c-f4c9be30b1ac.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-0b01bb0f-0ef2-4b7b-a092-36dc0c24022d.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-62cd7270-cdef-4326-8ef0-c7ff513ea24f.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-0c7c0714-cdb8-4f0e-930b-49f7996c9536.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-a2f0fce0-68ac-4001-864f-1fa8920b7d3e.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-f708a974-348c-494f-9e30-3d8a641446ba.docs.buildwithfern.com |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Plumbs through content-type within multipart form-data.
Also renames
FileUpload
toFormData
for clarity.Also fixes multipart form example generation inside FDR (by implementing requestBodyV3), although this should probably happen further upstream (in fern cli)... as a result this should fix the curl example generation.
snapshot test updated: https://github.com/fern-api/fern-platform/pull/780/files#diff-e098c79359d4943e85809e256c6a594ddb051bbc0f54fb9fff102fc834a2c3d0
deletes all instances of requestBody/responseBody in favor of requestBodyV3 and responseBodyV3 (since this the frontend only reads from v3). This will significantly reduce the amount of gzipped data that is sent over the wire.
not (fully) tested: multipart form snippet