Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plumb multipart form encoding in fdr #780

Merged
merged 12 commits into from
May 7, 2024

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented May 2, 2024

Plumbs through content-type within multipart form-data.

Also renames FileUpload to FormData for clarity.

Also fixes multipart form example generation inside FDR (by implementing requestBodyV3), although this should probably happen further upstream (in fern cli)... as a result this should fix the curl example generation.


snapshot test updated: https://github.com/fern-api/fern-platform/pull/780/files#diff-e098c79359d4943e85809e256c6a594ddb051bbc0f54fb9fff102fc834a2c3d0

deletes all instances of requestBody/responseBody in favor of requestBodyV3 and responseBodyV3 (since this the frontend only reads from v3). This will significantly reduce the amount of gzipped data that is sent over the wire.


not (fully) tested: multipart form snippet

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fern-dev ✅ Ready (Inspect) Visit Preview May 7, 2024 1:29am
3 Ignored Deployments
Name Status Preview Updated (UTC)
fern-prod ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 1:29am
fontawesome-cdn ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 1:29am
private-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 1:29am

@abvthecity abvthecity changed the title stash stash: multipart form encoding in fdr May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Copy link

github-actions bot commented May 3, 2024

Copy link

github-actions bot commented May 3, 2024

Copy link

github-actions bot commented May 3, 2024

Copy link

github-actions bot commented May 3, 2024

@abvthecity abvthecity changed the title stash: multipart form encoding in fdr feat: plumb multipart form encoding in fdr May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Copy link

github-actions bot commented May 7, 2024

Copy link

github-actions bot commented May 7, 2024

Copy link

github-actions bot commented May 7, 2024

Copy link

github-actions bot commented May 7, 2024

@abvthecity abvthecity merged commit 5ff5ffb into main May 7, 2024
20 of 21 checks passed
@abvthecity abvthecity deleted the ajiang/multipart-encoding branch May 7, 2024 01:41
Copy link

sentry-io bot commented May 9, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Failed to fetch blobToDataURL(app/src/api-playground/Playground... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not tested This PR has not been tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants