Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): docs respect auth prefix #602

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

dsinghvi
Copy link
Member

@dsinghvi dsinghvi commented Apr 2, 2024

No description provided.

@dsinghvi dsinghvi requested a review from abvthecity as a code owner April 2, 2024 23:15
Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fern-dev ❌ Failed (Inspect) Apr 2, 2024 11:22pm
3 Ignored Deployments
Name Status Preview Updated (UTC)
fern-prod ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2024 11:22pm
fontawesome-cdn ⬜️ Ignored (Inspect) Apr 2, 2024 11:22pm
private-docs ⬜️ Ignored (Inspect) Apr 2, 2024 11:22pm

Copy link

github-actions bot commented Apr 2, 2024

Copy link

github-actions bot commented Apr 2, 2024

PR Preview

Building...

@@ -387,7 +387,7 @@ export function buildUnredactedHeaders(
if (auth.type === "header") {
const value = header.headers[auth.headerWireValue];
if (value != null) {
headers[auth.headerWireValue] = value;
headers[auth.headerWireValue] = auth.prefix != null ? `${auth.prefix} ${value}` : value;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need this in buildRedactedHeaders as well

Copy link

github-actions bot commented Apr 2, 2024

Copy link

github-actions bot commented Apr 2, 2024

PR Preview

Building...

@dsinghvi dsinghvi merged commit e04b322 into main Apr 2, 2024
9 of 13 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/use-auth-header-prefix branch April 2, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants