Make Cloudfront private in CDK code, add key-pair for auth #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to dd/write-to-s3
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dubwub
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
dubwub
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
dubwub
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
dsinghvi
reviewed
Jan 23, 2025
.github/workflows/deploy-fdr-dev.yml
Outdated
| @@ -4,6 +4,7 @@ on: | |||
| push: | |||
| branches: | |||
| - main | |||
| - dd/write-to-s3 | |||
dubwub
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Failure
dubwub
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Failure
dsinghvi
approved these changes
Jan 23, 2025
dubwub
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
dubwub
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
dubwub
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Failure
dubwub
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Failure
dsinghvi
reviewed
Jan 23, 2025
dsinghvi
reviewed
Jan 23, 2025
| @@ -146,7 +147,7 @@ export class S3ServiceImpl implements S3Service { | |||
| }): Promise<PutObjectCommandOutput> { | |||
| const command = new PutObjectCommand({ | |||
| Bucket: this.config.dbDocsDefinitionS3.bucketName, | |||
| Key: `${domain}.json`, | |||
| Key: `${domain}/${docsDefinitionVersion()}.json`, | |||
There was a problem hiding this comment.
should be entirely replaced with getS3KeyForV1DocsDefinition
dsinghvi
reviewed
Jan 23, 2025
| @@ -10,7 +11,7 @@ export async function loadDocsDefinitionFromS3({ | |||
| }): Promise<FdrAPI.docs.v2.read.LoadDocsForUrlResponse | undefined> { | |||
| try { | |||
| const cleanDomain = domain.replace(/^https?:\/\//, ""); | |||
| const dbDocsDefUrl = `${docsDefinitionUrl}/${cleanDomain}.json`; | |||
| const dbDocsDefUrl = `${docsDefinitionUrl}/${cleanDomain}/${docsDefinitionVersion()}.json`; | |||
There was a problem hiding this comment.
${docsDefinitionUrl}/${getS3KeyForV1DocsDefinition(domain)}
dubwub
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Failure
dubwub
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.