-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: hide filesv2 from static props #2044
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
// "light" in logo && | ||
// "dark" in logo && | ||
// isFileIdOrUrl(logo.light) && | ||
// isFileIdOrUrl(logo.dark) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still working on a new home for this logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
📦 Next.js Bundle Analysis for fern-platform-monorepoThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Playwright test results 1 failed Details 101 tests across 9 suites Failed testschromium › forward-proxy/express.spec.ts › home page 404 Flaky testschromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for api.labelstud.io Skipped testschromium › forward-proxy/express.spec.ts › capture the flag |
in order to support S3'ifying all markdown files, we need to remove
filesV2
from being streamed to the frontend.before this pr, the files record is passed to the client-side and injected at runtime. after this pr, the files record is used to resolve file references on the server side.
this PR affects:
Embed
feat: support local embeds #2024)