fix: Correct pathing in OpenApi Parser Printing #2032
+68
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
📦 Next.js Bundle Analysis for fern-platform-monorepoThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Playwright test results
Details
Flaky testschromium › skew-protection/index.test.ts › should contain ?dpl= or x-deployment-id header on all scripts and prefetch requests Skipped testschromium › posthog.spec.ts › Posthog loads successfully |
dsinghvi
requested changes
Jan 16, 2025
There was a problem hiding this comment.
@RohinBhargava can you add some sort of testing on the fern check errors and make the snapshot testing capture the change in pathId
fern-support
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
fern-support
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes made
/, which is treated as~1in json paths~with~0in pathsitem[$index]-> the correct way to do this isitem/$index. We add the notion of passing an array of paths to model this without/getting replacedWhat was the motivation & context behind this PR?
How has this PR been tested?