Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(feature-flags): plumb feature flags to v1 #2030

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

dsinghvi
Copy link
Member

Short description of the changes made

This PR backports the feature flag functionality to V1.

What was the motivation & context behind this PR?

Allow the CLI to send up V1 nodes with feature flags.

How has this PR been tested?

N/A

@dsinghvi dsinghvi requested a review from abvthecity January 16, 2025 14:47
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 16, 2025 2:47pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 16, 2025 2:47pm

@dsinghvi dsinghvi marked this pull request as ready for review January 16, 2025 14:47
@dsinghvi dsinghvi had a problem deploying to Preview - app.buildwithfern.com January 16, 2025 14:47 — with GitHub Actions Failure
@dsinghvi dsinghvi had a problem deploying to Preview - app-dev.buildwithfern.com January 16, 2025 14:47 — with GitHub Actions Failure
Copy link

Copy link

Copy link

github-actions bot commented Jan 16, 2025

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

Copy link

github-actions bot commented Jan 16, 2025

PR Preview

Copy link

Copy link

github-actions bot commented Jan 16, 2025

Playwright test results

passed  97 passed
flaky  2 flaky
skipped  2 skipped

Details

stats  101 tests across 9 suites
duration  1 minute, 20 seconds
commit  c2a48e7

Flaky tests

chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for dev.documentation.sayari.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.stack-auth.com

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

Copy link

@dsinghvi dsinghvi merged commit 8c361ea into main Jan 16, 2025
16 of 18 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/plumb-feature-flags-to-v1 branch January 16, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants