feat: support local embeds #2024
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
chdeskur
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
chdeskur
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
| export const Embed: FC<ComponentProps<"embed">> = ({ src, ...rest }) => { | ||
| const files = useAtomValue(FILES_ATOM); | ||
|
|
||
| const fernEmbedSrc = useMemo((): DocsV1Read.File_ | undefined => { |
There was a problem hiding this comment.
probably good to make this a utility function and share it across the codebase. i imagine we'll do this more.
| strong: Strong, | ||
| }; | ||
|
|
||
| const ALIASED_HTML_COMPONENTS = { | ||
| Image, | ||
| Embed, |
There was a problem hiding this comment.
can we add one for video since you're here?
|
+1 to both, will scope to another PR |
📦 Next.js Bundle Analysis for fern-platform-monorepoThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Playwright test results
Details
Flaky testschromium › skew-protection/index.test.ts › should contain ?dpl= or x-deployment-id header on all scripts and prefetch requests Skipped testschromium › posthog.spec.ts › Posthog loads successfully |
This PR enables to reference locally-hosted files
Before:
After:
