feature: add server-side feature flags #2023

abvthecity · 2025-01-15T16:43:39Z

add FeatureFlags config block to navigation nodes, and evaluates it on the frontend
enables configuring sdk-key for server-side evaluations
uses the same logical and/or construct as with permissions
continue to pass the entire navigation hierarchy to enable client-side evaluation. we won't support server-side evaluation here, because server-side pruning is an auth feature.
use the feature flag to evaluate on the server-side whether or not to render a 404
pass the initial flags to the frontend to bootstrap SSR'd feature flag evaluation (prevent FOUC)

vercel · 2025-01-15T16:43:45Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
rbac.ferndocs.com	❌ Failed (Inspect)		Jan 15, 2025 4:43pm

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
fern-shell	⬜️ Ignored (Inspect)		Jan 15, 2025 4:43pm

github-actions · 2025-01-15T16:44:22Z

🌿 Preview your docs: https://fern-preview-5ec66b2d-ac87-4f72-a4c0-44cf4dc0b6dc.docs.buildwithfern.com

github-actions · 2025-01-15T16:45:15Z

🌿 Preview your docs: https://fern-preview-b6e6f83e-de88-4074-9cd2-a4eba7c56f1f.docs.buildwithfern.com

github-actions · 2025-01-15T16:45:30Z

🌿 Preview your docs: https://fern-preview-5b7291b9-152c-430b-ac04-2546e9832f98.docs.buildwithfern.com

github-actions · 2025-01-15T16:52:25Z

🌿 Preview your docs: https://fern-preview-4fa4ed53-f1c9-4662-8970-977fd18c3d65.docs.buildwithfern.com

github-actions · 2025-01-15T17:06:56Z

🌿 Preview your docs: https://fern-preview-a8b04bdb-3a06-455b-801c-4eaa1c6036e3.docs.buildwithfern.com

github-actions · 2025-01-15T17:12:48Z

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

RohinBhargava · 2025-01-15T17:12:49Z

packages/fern-docs/bundle/src/server/ld-adapter.ts

+    });
+}
+
+export const createLdPredicate = async ({


I take it this means that the logic is that node ff are or'd. Makes sense to me!

RohinBhargava

Looks great to me! I like that the adapter makes it so that this can be extended to other providers as well, if we need to support them

github-actions · 2025-01-15T17:15:54Z

PR Preview

github-actions · 2025-01-15T17:22:22Z

🌿 Preview your docs: https://fern-preview-c78381de-fff3-42cd-b32e-34c502f25927.docs.buildwithfern.com

github-actions · 2025-01-15T17:29:26Z

Playwright test results

95 passed
4 flaky
2 skipped

Details

101 tests across 9 suites
1 minute, 42 seconds
bd56541

Flaky tests

chromium › skew-protection/index.test.ts › should contain ?dpl= or x-deployment-id header on all scripts and prefetch requests
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for api.qdrant.tech
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.fluidstack.io
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.stack-auth.com

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

github-actions · 2025-01-15T17:30:28Z

🌿 Preview your docs: https://fern-preview-482ed7d9-e2e0-4496-a410-63a63df4191d.docs.buildwithfern.com

github-actions · 2025-01-15T17:33:11Z

🌿 Preview your docs: https://fern-preview-fd9cb96d-c95c-4720-a68b-7c7b79c97269.docs.buildwithfern.com

fix: add server-side feature flags

4fc8a56

vercel bot had a problem deploying to Preview – rbac.ferndocs.com January 15, 2025 16:43 Failure

abvthecity had a problem deploying to Fern Dev January 15, 2025 16:43 — with GitHub Actions Failure

abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com January 15, 2025 16:44 — with GitHub Actions Error

abvthecity had a problem deploying to Preview - app.buildwithfern.com January 15, 2025 16:44 — with GitHub Actions Error

add comment

b1c59e0

abvthecity had a problem deploying to Fern Dev January 15, 2025 16:44 — with GitHub Actions Failure

vercel bot had a problem deploying to Preview – rbac.ferndocs.com January 15, 2025 16:44 Failure

Merge branch 'main' into ajiang/add-feature-flag-settings

a819796

abvthecity had a problem deploying to Fern Dev January 15, 2025 16:44 — with GitHub Actions Failure

abvthecity marked this pull request as ready for review January 15, 2025 16:44

abvthecity requested review from RohinBhargava and dsinghvi as code owners January 15, 2025 16:44

abvthecity enabled auto-merge (squash) January 15, 2025 16:44

vercel bot had a problem deploying to Preview – rbac.ferndocs.com January 15, 2025 16:45 Failure

abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com January 15, 2025 16:45 — with GitHub Actions Failure

abvthecity had a problem deploying to Preview - app.buildwithfern.com January 15, 2025 16:45 — with GitHub Actions Failure

fix checks

8a3387d

abvthecity had a problem deploying to Fern Dev January 15, 2025 16:51 — with GitHub Actions Failure

vercel bot had a problem deploying to Preview – rbac.ferndocs.com January 15, 2025 16:51 Failure

abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com January 15, 2025 16:52 — with GitHub Actions Failure

abvthecity had a problem deploying to Preview - app.buildwithfern.com January 15, 2025 16:52 — with GitHub Actions Failure

fix

fed6350

abvthecity temporarily deployed to Fern Dev January 15, 2025 16:56 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview – rbac.ferndocs.com January 15, 2025 16:56 Failure

dsinghvi approved these changes Jan 15, 2025

View reviewed changes

fix more tests

770fc23

abvthecity temporarily deployed to Fern Dev January 15, 2025 17:06 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview – rbac.ferndocs.com January 15, 2025 17:06 Failure

abvthecity deployed to Preview - app.buildwithfern.com January 15, 2025 17:06 — with GitHub Actions View deployment

abvthecity deployed to Preview - app-dev.buildwithfern.com January 15, 2025 17:06 — with GitHub Actions View deployment

RohinBhargava reviewed Jan 15, 2025

View reviewed changes

RohinBhargava approved these changes Jan 15, 2025

View reviewed changes

fix snaps

9ae83b0

abvthecity temporarily deployed to Fern Dev January 15, 2025 17:18 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview – rbac.ferndocs.com January 15, 2025 17:18 Failure

add debug mode for mdx

b58a6f6

abvthecity temporarily deployed to Fern Dev January 15, 2025 17:29 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview – rbac.ferndocs.com January 15, 2025 17:29 Failure

abvthecity had a problem deploying to Preview - app.buildwithfern.com January 15, 2025 17:29 — with GitHub Actions Error

abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com January 15, 2025 17:29 — with GitHub Actions Error

move utilities into fern-docs/components

bd56541

abvthecity temporarily deployed to Fern Dev January 15, 2025 17:31 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview – rbac.ferndocs.com January 15, 2025 17:31 Failure

abvthecity deployed to Preview - app.buildwithfern.com January 15, 2025 17:31 — with GitHub Actions View deployment

abvthecity deployed to Preview - app-dev.buildwithfern.com January 15, 2025 17:31 — with GitHub Actions View deployment

abvthecity merged commit 785f1e7 into main Jan 15, 2025
18 of 20 checks passed

abvthecity deleted the ajiang/add-feature-flag-settings branch January 15, 2025 17:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: add server-side feature flags #2023

feature: add server-side feature flags #2023

abvthecity commented Jan 15, 2025 •

edited

Loading

vercel bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025 •

edited

Loading

RohinBhargava Jan 15, 2025

RohinBhargava left a comment

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

feature: add server-side feature flags #2023

feature: add server-side feature flags #2023

Conversation

abvthecity commented Jan 15, 2025 • edited Loading

vercel bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025 • edited Loading

📦 Next.js Bundle Analysis for fern-platform-monorepo

RohinBhargava Jan 15, 2025

Choose a reason for hiding this comment

RohinBhargava left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 15, 2025 • edited Loading

PR Preview

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025 • edited Loading

Playwright test results

Details

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

abvthecity commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading