Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable details based accordions #2020

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Jan 15, 2025

details based accordions enable cmd+f functionality

  • copied primitive implementation from @radix-ui/react-accordion
  • updated the implementation to use <details> and <summary>
  • moved into @fern-docs/components for reusability

note: collapse animation is gone because of the way <details> work out of the box. We'll need to update the implementation slightly to support closing animation in the future.

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 15, 2025 6:49am
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 15, 2025 6:49am

@abvthecity abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com January 15, 2025 06:50 — with GitHub Actions Error
@abvthecity abvthecity had a problem deploying to Preview - app.buildwithfern.com January 15, 2025 06:50 — with GitHub Actions Error
Copy link

github-actions bot commented Jan 15, 2025

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Jan 15, 2025

PR Preview

@abvthecity abvthecity marked this pull request as ready for review January 15, 2025 06:59
@abvthecity abvthecity requested a review from dsinghvi as a code owner January 15, 2025 06:59
@abvthecity abvthecity enabled auto-merge (squash) January 15, 2025 06:59
@abvthecity abvthecity had a problem deploying to Preview - app.buildwithfern.com January 15, 2025 07:00 — with GitHub Actions Failure
@abvthecity abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com January 15, 2025 07:00 — with GitHub Actions Failure
@abvthecity abvthecity had a problem deploying to Preview - app.buildwithfern.com January 15, 2025 07:05 — with GitHub Actions Error
Copy link

Playwright test results

passed  99 passed
skipped  2 skipped

Details

stats  101 tests across 9 suites
duration  47.9 seconds
commit  a6bb8cf

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

@abvthecity abvthecity merged commit 16e4f7f into main Jan 15, 2025
16 of 19 checks passed
@abvthecity abvthecity deleted the ajiang/disclosure-based-accordion branch January 15, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants