Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better example generation, add parameter definitions #2018

Merged
merged 13 commits into from
Jan 15, 2025

Conversation

RohinBhargava
Copy link
Member

@RohinBhargava RohinBhargava commented Jan 15, 2025

Short description of the changes made

  • Adds parameters to example parsing
  • Simplifies the logic for Examples and makes it clear where to plumb snippets and merge -> now we parse redoc, x-fern-examples and oai examples independently, falling back to an autogenerated example if none is found
  • Fixes issues where null checking was short circuiting

What was the motivation & context behind this PR?

  • Customer feedback

How has this PR been tested?

  • snapshots and unit tests

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 15, 2025 1:33am
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 15, 2025 1:33am

Copy link

github-actions bot commented Jan 15, 2025

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Jan 15, 2025

PR Preview

Copy link

github-actions bot commented Jan 15, 2025

Playwright test results

passed  96 passed
flaky  3 flaky
skipped  2 skipped

Details

stats  101 tests across 9 suites
duration  1 minute, 15 seconds
commit  9f24889

Flaky tests

chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for api.qdrant.tech
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for developers.gappify.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.darwincloud.xyz

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

Copy link
Member

@dsinghvi dsinghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments around quality of life/code legibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants