Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure nullable shows in api reference #2010

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

RohinBhargava
Copy link
Member

Short description of the changes made

  • nullable was not showing up correctly in the api reference, now we make sure that it renders correctly

What was the motivation & context behind this PR?

  • customer demand

How has this PR been tested?

image

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 14, 2025 5:14pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 14, 2025 5:14pm

Copy link

github-actions bot commented Jan 14, 2025

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Jan 14, 2025

PR Preview

@RohinBhargava RohinBhargava marked this pull request as ready for review January 14, 2025 17:29
Copy link

github-actions bot commented Jan 14, 2025

Playwright test results

passed  99 passed
skipped  2 skipped

Details

stats  101 tests across 9 suites
duration  1 minute, 6 seconds
commit  47fab22

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

@RohinBhargava RohinBhargava merged commit 530833a into main Jan 21, 2025
16 of 17 checks passed
@RohinBhargava RohinBhargava deleted the rohin/render-nullables branch January 21, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants