Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fdr): make sure that cdk does not reset files response header p… #1975

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dsinghvi
Copy link
Member

@dsinghvi dsinghvi commented Jan 9, 2025

Short description of the changes made

Makes sure that the files.buildwithfern.com cloudfront returns a * header for the access control origin.

What was the motivation & context behind this PR?

Do not want to roll back the response header policy on the next FDR release.

How has this PR been tested?

References the exact policy that we manually created.

@dsinghvi dsinghvi marked this pull request as ready for review January 9, 2025 19:31
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 9, 2025 7:31pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 9, 2025 7:31pm

Copy link

github-actions bot commented Jan 9, 2025

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Jan 9, 2025

PR Preview

Copy link

github-actions bot commented Jan 9, 2025

Playwright test results

passed  95 passed
flaky  4 flaky
skipped  4 skipped

Details

stats  103 tests across 10 suites
duration  1 minute, 31 seconds
commit  6a634d5

Flaky tests

chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for api.qdrant.tech
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.aiaplatform.com.au
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.cohere.com
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.kota.io

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request
chromium › websockets/websocket.spec.ts › websocket test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants