Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hard navigate on 404 #1663

Merged
merged 1 commit into from
Oct 12, 2024
Merged

fix: hard navigate on 404 #1663

merged 1 commit into from
Oct 12, 2024

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Oct 12, 2024 •
edited
Loading

adds a feature flag that always hard navigates on 404.

@abvthecity abvthecity marked this pull request as ready for review October 12, 2024 16:06
@abvthecity abvthecity requested a review from dsinghvi as a code owner October 12, 2024 16:06
@abvthecity abvthecity enabled auto-merge (squash) October 12, 2024 16:06
@github-actions GitHub Actions
Copy link

Playwright test results

passed  1 passed

Details

stats  1 test across 1 suite
duration  9 seconds
commit  c268f3d

@github-actions GitHub Actions
Copy link

PR Preview

@github-actions GitHub Actions
Copy link

Playwright test results

passed  81 passed

Details

stats  81 tests across 3 suites
duration  1 minute, 11 seconds
commit  c268f3d

@abvthecity abvthecity merged commit ecc47b3 into main Oct 12, 2024
22 of 23 checks passed
@abvthecity abvthecity deleted the ajiang/hard-navigate-on-404 branch October 12, 2024 16:20
@abvthecity abvthecity mentioned this pull request Oct 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsinghvi dsinghvi dsinghvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abvthecity @dsinghvi